Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #121131

Merged
merged 23 commits into from
Feb 15, 2024
Merged

Rollup of 10 pull requests #121131

merged 23 commits into from
Feb 15, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Stargateur and others added 23 commits June 21, 2023 16:51
These were changed to `has_errors` assertions in rust-lang#121071 because that
seemed reasonable, but evidently not.

Fixes rust-lang#121103.
Fixes rust-lang#121108.
…n source order even if early-bound params are present
Add known issue of let binding to format_args doc

Simply add doc about rust-lang#92698.

 `@rustbot` label +T-rustdoc -T-libs

 r? `@GuillaumeGomez`
Make contributing to windows bindings easier

This PR does three things:

- Automatically sorts bindings so contributors don't have to. I should have done this to begin with but was lazy.
- Renames `windows_sys.lst` to `bindings.txt`. This [matches the windows-rs repository](https://github.com/microsoft/windows-rs/blob/8e71051ea8a57594478e585d2740126893f9dbb7/crates/tools/sys/bindings.txt) (and repos that copy it). I believe consistency with other projects helps get people orientated.
- Adds a `README.md` file explaining what this is about and how to add bindings. This has the benefit of being directly editable and it's rendered when viewed online. Also people are understandably jumping right into the `windows_sys.rs` file via ripgrep or github search and so missing that it's generated. A `README.md` alongside it is at least slightly more obvious in that case. There is still a small note at the top of `windows_sys` in case people do read from the beginning.

None of this has any impact on the actual code generated. It's purely to make the new contributors workflow a bit nicer.
…lt-src-order, r=GuillaumeGomez

rustdoc: cross-crate re-exports: correctly render late-bound params in source order even if early-bound params are present

r? ghost
Clarified docs on non-atomic oprations on owned/mut refs to atomics

I originally misinterpreted the documentation to mean that the compiler can/will automatically optimise away atomic operations whenever the data is owned or mutably referenced.

On re-reading I think it is not technically incorrect, but specifically mentioning _how_ the atomic operations can be avoided also prevents this misunderstanding.
…=WaffleLapkin

Make sure `tcx.create_def` also depends on the forever red node, instead of just `tcx.at(span).create_def`

oversight from rust-lang#119136

Not actually an issue, because all uses of `tcx.create_def` were in the resolver, which is `eval_always`, but still good to harden against future uses of `create_def`

cc `@petrochenkov` `@WaffleLapkin`
…ary-else, r=Nilstrieb

Remove unnecessary else block from `thread_local!` expanded code

Some expanded codes make ["unnecessary else block" warnings](rust-lang/rust-analyzer#16556 (comment)) for Rust Analyzer
…ow, r=oli-obk

Do not report overflow errors on ConstArgHasType goals

This is 10% of a fix for rust-lang#121090, since it at least means that we no longer mention the `ConstArgHasType` goal as the cause for the overflow. Instead, now we mention:
```
overflow evaluating the requirement `{closure@$DIR/overflow-during-mono.rs:13:41: 13:44}: Sized`
```
which is not much better, but slightly.

r? oli-obk
…li-obk

Reinstate some delayed bugs.

These were changed to `has_errors` assertions in rust-lang#121071 because that seemed reasonable, but evidently not.

Fixes rust-lang#121103.
Fixes rust-lang#121108.
… r=oli-obk

Enforce coroutine-closure layouts are identical

Enforce that for an async closure, the by-ref and by-move coroutine layouts are identical. This is just a sanity check to make sure that optimizations aren't doing anything fishy.

r? oli-obk
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 15, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented Feb 15, 2024

📌 Commit 829b59a has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024
@bors
Copy link
Contributor

bors commented Feb 15, 2024

⌛ Testing commit 829b59a with merge 4ae1e79...

@bors
Copy link
Contributor

bors commented Feb 15, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4ae1e79 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 15, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4ae1e79 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Feb 15, 2024
@bors bors merged commit 4ae1e79 into rust-lang:master Feb 15, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 15, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#111106 Add known issue of let binding to format_args doc 59b4403e9b329e2f3e8a7e804b3e0f0974118631 (link)
#118749 Make contributing to windows bindings easier 3d91fd8291c5b1fef3ed85b2316f70deb366c2bb (link)
#120982 Add APIs for fetching foreign items 6203dcee17e6d04b80c0dc1cde754ab0b529cf76 (link)
#121022 rustdoc: cross-crate re-exports: correctly render late-boun… 9fb85cbed98ca4c2e327902e38e2fca9f553df63 (link)
#121082 Clarified docs on non-atomic oprations on owned/mut refs to… fb4cce3b9049dd79e8656c84ff90e2e0b63b8f87 (link)
#121084 Make sure tcx.create_def also depends on the forever red … a604466fae61d27452d15a9f5f9c653865deacc7 (link)
#121098 Remove unnecessary else block from thread_local! expanded… ce335f16b04a548876be512ab97e95c689d53da8 (link)
#121105 Do not report overflow errors on ConstArgHasType goals 066fce77cdb0a98fe88aaa32dc0438f61fe23aba (link)
#121116 Reinstate some delayed bugs. 40402cdb7c8939f2c098feff47907133c02f5f19 (link)
#121122 Enforce coroutine-closure layouts are identical 45ee290fc47c461275039fbeb5512d6f5b8f64ce (link)

previous master: bd6b336133

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Feb 15, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4ae1e79): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.2% [5.5%, 6.8%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 1

Bootstrap: 636.704s -> 635.116s (-0.25%)
Artifact size: 306.15 MiB -> 306.13 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-mo3b8nz branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.